Skip to content

Conversation

@Swedz
Copy link
Collaborator

@Swedz Swedz commented Nov 25, 2024

Contains some parts of #900

@Technici4n
Copy link
Contributor

I don't think the models in MI would be too happy with this?

@Swedz
Copy link
Collaborator Author

Swedz commented Nov 25, 2024

I'd need to double check later, but this change only allows for machines to explicitly allow vertical orientations and by default wouldn't be any different. My goal for this is to update the Machine Chainer from EI to let it face up and down. I can give more info on this when I get back to my desk later tonight

@Technici4n
Copy link
Contributor

Would setting canBeVertical to true not cause problems with MI's models? If yes just add a comment that it needs a custom model. I'd also add a comment that this is for addons, but that MI itself does not use it. (So it doesn't get removed accidentally).

@Swedz
Copy link
Collaborator Author

Swedz commented Nov 26, 2024

Yes it would, I made a custom loader for the machine chainer to be able to use this new flag. Its part of why I wanted to revamp a bit of the machine model stuff in #900 as well. It lets me extend MachineBakedModel and MachineOverlaysJson to easily get a lot of the same functionality while also not having to copy paste a large part of the MI code. I can add a comment making this clear. If you're at all curious, here is what my machine chainer's baked model looks like using these changes, if anything to get an idea of how this is used.

@Technici4n Technici4n merged commit 9374e59 into AztechMC:1.21.x Nov 27, 2024
1 check passed
@Swedz Swedz deleted the vertical-orientations branch December 10, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants